workflows: run ML tests requiring docker-in-docker environment on ubuntu-latest#35698
Conversation
|
Important Installation incomplete: to start using Gemini Code Assist, please ask the organization owner(s) to visit the Gemini Code Assist Admin Console and sign the Terms of Services. |
mohamedawnallah
force-pushed
the
ubuntu-latest-on-postcommit-python-and-ml
branch
2 times, most recently
from
48c4bb0 to
2a1ef8f
Compare
|
cc: @damccorm |
|
I think missed the |
In this commit, we run ML tests requiring docker-in-docker environment on `ubuntu-latest`. The motivation behind this is Milvus itests was requiring docker-in-docker environment due to setup issues on beam CI self-hosted environment.
mohamedawnallah
force-pushed
the
ubuntu-latest-on-postcommit-python-and-ml
branch
from
2a1ef8f to
a71dc4f
Compare
Resolved them. I think PR now ready for review |
|
Assigning reviewers: R: @Abacn for label build. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
damccorm
left a comment
damccorm
left a comment
There was a problem hiding this comment.
Thanks! We can try this out
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
3 participants
Description
Given that we have support for pytest user markers (#35655), we can extend this functionality to our post/pre commit workflows targeting ML tests on the first iteration mainly for Milvus itests.
Motivation and Context
#35585
#35598 (reverted because pytest user markers wasn't allowed back then)
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.